[TAN-5736] Remove dead code related to legacy file classes #12406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
TAN-5735/delete-legacy-file-records
to
master
October 31, 2025 08:49
adessy
force-pushed
the
TAN-5736/dead-code-legacy-files
branch
from
7ffe0f6 to
8136f25
Compare
Collaborator
|
The file_attachments_as_legacy_files_spec.rb overlapped with other acceptance tests, especially idea_files_spec.rb and project_files_spec.rb. This commit removes the redundant file and integrates the relevant parts into the existing test files to reduce duplication.
adessy
force-pushed
the
TAN-5736/dead-code-legacy-files
branch
from
1cf7599 to
2ee9f34
Compare
jamesspeake
approved these changes
Nov 10, 2025
Contributor
jamesspeake
left a comment
jamesspeake
left a comment
There was a problem hiding this comment.
Looks good to me generally, but with a couple of questions
|
|
||
| resource 'EventFile' do | ||
| explanation 'File attachments.' | ||
| resource 'File attachment as legacy EventFile' do |
Contributor
There was a problem hiding this comment.
Do we need legacy here? Could we not just say File attachments for Events or is there further work and the whole files controller is considered legacy and will be removed at some point?
| end | ||
|
|
||
| describe do | ||
| # [TODO] Currently, the +Files::FileUploader+ allows all file extensions. |
Contributor
There was a problem hiding this comment.
Is this going to be fixed? Feels like it's a security hole to not tighten this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much shorter in terms of the number of lines because I have a fairly spacious coding style 🥲
Changelog
Technical
WebApi::V1::FilesControllerandWebApi::V1::IdeasController.